Ensure SplunkJenkinsInstallation.load calculates metadataItemSet
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Sep 29, 2023
| @Override | ||
| public synchronized final void load() { | ||
| super.load(); | ||
| migrate(); |
There was a problem hiding this comment.
Hide whitespace to see a shorter diff.
| cfg.load(); | ||
| Set<MetaDataConfigItem> metadataItemSet = cfg.getMetadataItemSet(); | ||
| assertThat(metadataItemSet, hasSize(1)); | ||
| assertThat(metadataItemSet.iterator().next().getValue(), is("value999")); |
There was a problem hiding this comment.
Without main patch, the value is still value000: metaDataConfig has been loaded from disk but
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of CloudBees CI in High Availability mode noticed that after saving
SplunkJenkinsInstallationon one replica, another replica failed to reflect the updated value inmetadataItemSet. This seems to be because as of b6c8513 this state istransient; it does get calculated in the constructor, but not generally inload, which CloudBees CI would call (see jenkinsci/jenkins#8544) when synchronizingGlobalConfiguration. I am not sure if this issue would affect other users;POST /reloador CLIreload-configurationcurrently looks like it reloads$JENKINS_HOME/config.xmlbut not otherGlobalConfigurations, which may be a core bug. CC @Vlatombe