Only fetch unresolved issues

[mtughan]

When fetching issues from SonarQube, we should only fetch unresolved issues. This will avoid showing issues which were discovered in previous runs with the same "PR" ID but have since been resolved and are no longer issues.

Testing done

Tested manually in our local environment.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[mtughan]

Actually, this PR may still have some issues. Working through them now. Please do not merge yet.

[reda-alaoui]

Please add at least one automated test

[mtughan]

@reda-alaoui, this has been fully tested locally now and resolves our issue nicely. I've also added an automated test to verify the requests that are being sent to SonarQube. Please review when you are able.

[reda-alaoui]

@mtughan , unit tests have low value in this case. Please write an integration test instead.

[mtughan]

@mtughan , unit tests have low value in this case. Please write an integration test instead.

Testing an integration test now. Will request review again when I've confirmed it as working (am having issues running it locally).

[mtughan]

@reda-alaoui, PullRequestAnalysisTest doesn't seem to be getting executed in the PR runs, either on Linux or on Windows. Any idea why that would be?

12:48:56  [INFO] Running org.jenkinsci.plugins.sonargerrit.sonar.pull_request_analysis.PullRequestAnalysisTest
12:50:12  [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 75.834 s - in org.jenkinsci.plugins.sonargerrit.sonar.pull_request_analysis.PullRequestAnalysisTest

[reda-alaoui]

@mtughan , I am currently investigating this.

[reda-alaoui]

@mtughan please rebase on master to retrieve d12b988 .

[mtughan]

@mtughan please rebase on master to retrieve d12b988 .

Will do, thanks.

UPDATE: Yes, it appears to be fixed now. I will troubleshoot and get the unit test working now.

[felipecrs]

As a user of this plugin, I'd like to cast my support for this PR. It would be great if it avoided posting comments for resolved issues. :)