Add an optiona allowing to prevent duplicated comments on subsequent patchsets #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reda-alaoui
requested changes
Jul 28, 2023
src/main/java/org/jenkinsci/plugins/sonargerrit/gerrit/GerritReviewBuilder.java
Outdated
Show resolved
Hide resolved
reda-alaoui
requested changes
Jul 29, 2023
There was a problem hiding this comment.
I don't see any reason to populate this class. If I remember correctly, as its name indicates, it is only kept for backward compatibility reason and therefore should not be enriched anymore.
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/sonargerrit/SonarToGerritPublisher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/sonargerrit/gerrit/ReviewConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/sonargerrit/gerrit/ReviewConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/sonargerrit/util/BackCompatibilityHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/sonargerrit/util/BackCompatibilityHelper.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jenkinsci/plugins/sonargerrit/config/NullValuesTest.java
Outdated
Show resolved
Hide resolved
Enhance explanation of omitDuplicateComments and do not handle it for back compatibility. Co-authored-by: Réda Housni Alaoui <[email protected]>
reda-alaoui
approved these changes
Jul 31, 2023
reda-alaoui
changed the title
|
Thank you ! |
|
Thank you for your support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #143
In GerritReviewBuilder set omitDuplicateComments of ReviewInput.
Testing done
Submitter checklist