Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to override default gerrit http credentials #10

Merged

Conversation

maksonlee
Copy link
Contributor

No description provided.

@aquarellian
Copy link
Contributor

Thank you for the contribution! And sorry for the delay - I missed the notification about your pull request.

Regarding the change, I'd add a button "Test connection", similar to the way how it is implemented in the Gerrit Trigger.
If you have time, I'd be grateful if you can do it. Otherwise I'll do it myself, let me know.

I'll merge your change to the plugin shortly.

@maksonlee
Copy link
Contributor Author

When job is running, a build object is passed to peform() method so you can get related gerrit information from it, but how to do that when we are configuring job?

@aquarellian aquarellian merged commit 07a3c2e into jenkinsci:master Mar 31, 2017
@aquarellian
Copy link
Contributor

The only way I've found is to allow user to choose a Gerrit server to be used for credentials check. Thank you for the contribution, this feature will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants