Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inline js for favicon #215

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Aug 23, 2024

favicon generates inline js which is not CSP compliant. This changes it so the url is provided via a data-url attribute of the script.
Also simplifies a bit the javascript and uses modern syntax.

Testing done

Manual testing that favicon still works
Verified with CSP plugin that there are no errors related to favicon

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

favicon generated inline js which is not CSP compliant.
This changes it so the url is provided via data-url attribute of the
script.
@mawinter69 mawinter69 requested a review from a team as a code owner August 23, 2024 20:03
@TobiX TobiX merged commit 96d9592 into jenkinsci:main Aug 27, 2024
16 checks passed
@TobiX
Copy link
Contributor

TobiX commented Aug 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants