Use plugin bom for dependency version definitions #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent plugin bill of materials provides the authorize-project plugin version. Use that version rather than managing the version drectly in the plugin pom. Apache commons-lang3-api is available as an API plugin that is managed by the bom. Test with the API plugin rather than including commons-lang3-api in the tests. Testing with the API plugin has the added benefit that it is using the same version that is installed in many Jenkins controllers.
MarkEWaite
force-pushed
the
remove-authorize-project-version-declaration
branch
from
0f27746 to
6977d17
Compare
mawinter69
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use plugin bom for dependency version definitions
The most recent plugin bill of materials provides the authorize-project plugin version. Use that version rather than managing the version drectly in the plugin pom.
Apache commons-lang3-api is available as an API plugin that is managed by the bom. Test with the API plugin rather than including commons-lang3-api in the tests. Testing with the API plugin has the added benefit that it is using the same version that is installed in many Jenkins controllers.
Testing done
Automated tests pass on my Linux with Java 11.
Submitter checklist