[JENKINS-71772] Use authorize-project plugin as a test dependency #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.jenkins.io/browse/JENKINS-71772 notes that jenkinsci@a5f2767 inadvertently changed the authorize-project plugin from a test dependency to a runtime dependency. The code compiles correctly without the runtime dependency and the tests pass on my Linux computer with Java 11. jenkinsci/bom#2340 added authorize-project plugin to the plugin bill of materials because I didn't detect that the new dependency was not needed at runtime. Thanks to James Holderness for reporting the issue.
mawinter69
approved these changes
Aug 7, 2023
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JENKINS-71772] Use authorize-project plugin as a test dependency
JENKINS-71772 notes that a5f2767 inadvertently changed the authorize-project plugin from a test dependency to a runtime dependency. The code compiles correctly without the runtime dependency and the tests pass on my Linux computer with Java 11.
jenkinsci/bom#2340 added authorize-project plugin to the plugin bill of materials because I didn't detect that the new dependency was not needed at runtime.
Thanks to James Holderness for reporting the issue.
Testing done
Confirmed that compilation succeeds and automated tests pass with the authorize-project plugin dependency switched back to a test dependency instead of a runtime dependency.
Submitter checklist