Fix @since fields in Javadoc + Use the new Role Strategy APIs with enum in the naming strategy and tests
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhyudayaSharma
approved these changes
Jan 2, 2020
src/main/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleMap.java
Outdated
Show resolved
Hide resolved
…eMap.java Co-Authored-By: Abhyudaya Sharma <[email protected]>
oleg-nenashev
changed the title
@since fields in Javadoc + Use the new Role Strategy APIs with enum in tests
oleg-nenashev
changed the title
@since fields in Javadoc + Use the new Role Strategy APIs with enum in tests@since fields in Javadoc + Use the new Role Strategy APIs with enum in the naming strategy and tests
oleg-nenashev
approved these changes
Jan 2, 2020
| @@ -41,13 +43,13 @@ public void checkName(String name) throws Failure { | |||
| if (auth instanceof RoleBasedAuthorizationStrategy){ | |||
| RoleBasedAuthorizationStrategy rbas = (RoleBasedAuthorizationStrategy) auth; | |||
| //firstly check global role | |||
| SortedMap<Role, Set<String>> gRole = rbas.getGrantedRoles(RoleBasedAuthorizationStrategy.GLOBAL); | |||
| SortedMap<Role, Set<String>> gRole = rbas.getGrantedRoles(RoleType.Global); | |||
There was a problem hiding this comment.
It may actually imply some performance differences, but it is fine in the case of this extension
There was a problem hiding this comment.
I double checked it, somehow performance is worse, and I'm doubting the bench tests for #119 and #118 they both show similar performance losses as what i saw from here. I took the tip of master and compared it to the benches for all 3 PRs. It seems like the baseline is off. Maybe an infra change is causing this Inaccuracy I might run the benches locally to verify.
In this exact case performance should improve or be of negligible difference since this reduces it by 2 calls conversion from string to enum and calling the non deprecated function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanups and update the since/todo comments