Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable --worktree option to repo init #66

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add option to enable --worktree option to repo init #66

merged 1 commit into from
Sep 29, 2020

Conversation

abioteau
Copy link

@abioteau abioteau commented Aug 24, 2020

The "worktree" option is absolutely necessary under Windows to not use symlink which requires administration rights.

@abioteau
Copy link
Author

abioteau commented Aug 25, 2020

It seems that CI failure is due to the use of the newest Warning Next Generation Plugin. Current configuration in JenkinsFile is obsolete.

`[2020-08-24T14:10:13.375Z] WARNING: Unknown parameter(s) found for class type 'io.jenkins.plugins.analysis.core.steps.RecordIssuesStep': archive,run

[2020-08-24T14:10:14.588Z] [CheckStyle] Searching for all files in '/home/jenkins/workspace/Plugins_repo-plugin_PR-66' that match the pattern '**/target/checkstyle-result.xml'

[2020-08-24T14:10:14.588Z] [CheckStyle] -> found 1 file

[2020-08-24T14:10:14.588Z] [CheckStyle] Successfully parsed file /home/jenkins/workspace/Plugins_repo-plugin_PR-66/target/checkstyle-result.xml

[2020-08-24T14:10:14.588Z] [CheckStyle] -> found 0 issues (skipped 0 duplicates)

[2020-08-24T14:10:14.588Z] [CheckStyle] Skipping post processing

[2020-08-24T14:10:14.588Z] [CheckStyle] No filter has been set, publishing all 0 issues

[2020-08-24T14:10:14.600Z] [CheckStyle] No valid reference build found that meets the criteria (NO_JOB_FAILURE - SUCCESSFUL_QUALITY_GATE)

[2020-08-24T14:10:14.600Z] [CheckStyle] All reported issues will be considered outstanding

[2020-08-24T14:10:14.601Z] [CheckStyle] Evaluating quality gates

[2020-08-24T14:10:14.601Z] [CheckStyle] -> PASSED - Total (any severity): 0 - Quality QualityGate: 1

[2020-08-24T14:10:14.601Z] [CheckStyle] -> WARNING - Total (any severity): 0 - Quality QualityGate: 0

[2020-08-24T14:10:14.601Z] [CheckStyle] -> Some quality gates have been missed: overall result is WARNING

[2020-08-24T14:10:14.601Z] [CheckStyle] Health report is disabled - skipping

[2020-08-24T14:10:14.601Z] [CheckStyle] Created analysis result for 0 issues (found 0 new issues, fixed 0 issues)

[2020-08-24T14:10:14.601Z] [CheckStyle] Attaching ResultAction with ID 'checkstyle' to run 'Plugins/repo-plugin/PR-66 #1'.

[2020-08-24T14:10:14.651Z] Publishing GitHub check...`

@abioteau
Copy link
Author

To fix CI, a commit should be done in master branch at least to configure newest Warning Next Generation Plugin.

I did 2 commits on https://github.com/abioteau/repo-plugin/tree/fix-ci for that purpose but i cannot test it because only trusted revision of JenkinsFile can be used by CI.

@abioteau
Copy link
Author

Dear @rsandell, could you have a look on CI failure?

@abioteau
Copy link
Author

@rsandell could you update JenkinsFile to fix CI?

@abioteau
Copy link
Author

@rsandell , @aep , @bjarkef, @Typz : can you please review this PR ?

@aep
Copy link
Member

aep commented Sep 28, 2020

not really, very sorry. Haven't been using jenkins for years, and i really would prefer not being listed as maintainer.

the change looks good to me tho

@abioteau
Copy link
Author

@aep I apologize for the inconvenience.

Copy link

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francoisferrand francoisferrand merged commit ed5bb7e into jenkinsci:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants