Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for --no-clone-bundle #53

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

qcspewa
Copy link

@qcspewa qcspewa commented Oct 23, 2018

Added "No Clone Bundle" setting. If selected the "repo init" and "repo sync" commands will
be run with the --no-clone-bundle option.

I have tried it with both standard jobs and pipelines.

@abioteau
Copy link

Please, could you also apply it on "repo init" command.

@qcspewa
Copy link
Author

qcspewa commented Oct 24, 2018

I have applied it to "repo init" as well and have updated the pull request accordingly

@qcspewa qcspewa closed this Oct 24, 2018
@qcspewa qcspewa reopened this Oct 24, 2018
@unullmass
Copy link

unullmass commented Apr 1, 2019

@rsandell this functionality will be very helpful. I was looking for this in the current release of the plugin before I realised this hasn't been merged yet. Please approve the PR. :-)

@zwx168238
Copy link

@rsandell this functionality will be very helpful. I was looking for this in the current release of the plugin before I realised this hasn't been merged yet. Please approve the PR. :-)

+1

@aksenov007
Copy link

@rsandell What blocks this to be merged?

Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing, my available time for this plugin is very limited unfortunately.

src/main/java/hudson/plugins/repo/RepoScm.java Outdated Show resolved Hide resolved
Added "No Clone Bundle" setting. If selected the "repo init" and "repo sync"
commands will be run with the --no-clone-bundle option.
@qcspewa qcspewa requested a review from rsandell October 21, 2019 09:04
Copy link
Member

@rsandell rsandell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked to see a test for this as well, the tests in this plugin are very sparse, so I understand that wasn't a priority.

@rsandell rsandell merged commit 6b89ae4 into jenkinsci:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants