Fix raw diff parsing #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
reviewed
Oct 18, 2019
| @@ -78,28 +69,10 @@ public String getPath() { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the action performed on the file. | |||
| */ | |||
| public char getAction() { | |||
There was a problem hiding this comment.
This breaks binary compatibility by removing a public signature.
But the risk of breaking something is very low as it is not a very popular plugin and the class is package protected.
But bare that in mind for your next awesome contribution :)
|
I would have liked to see a test case for this. |
|
It looks like this PR served to fix https://issues.jenkins-ci.org/browse/JENKINS-49829 (errors like "java.lang.StringIndexOutOfBoundsException: String index out of range: -1"), correct? |
|
Think so yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code assumed the action/path were always at fixed positions in the line. This is not the case for at least 2 reasons:
The new code splits by space/tab as per the format described in "git diff --help". This could still break if you have filenames containing tabs but it's certainly better.
I've also gotten rid of the made-up rename EditType and just used an add+delete instead. Without support for renaming at a higher level this seems better.