Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Force Sync option to repo plugin #26

Merged
merged 4 commits into from
Sep 25, 2015

Conversation

andrewgoktepe
Copy link

This adds a new checkbox option called "Force Sync" which will add the --force-sync option when running "repo sync".

@andrewgoktepe
Copy link
Author

The Jenkins build failed at checkstyle. The first error is unrelated to my change. The second issue is complaining about the number of parameters in the constructor, which I'm not sure is a showstopper.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@rsandell
Copy link
Member

rsandell commented Sep 2, 2015

Well we should avoid putting more options into the constructor. Better to add a

@DataBoundSetter
public void setForceSync(boolean forceSync)

@rsandell
Copy link
Member

rsandell commented Sep 2, 2015

And if I run checkstyle on the master now, there are no checkstyle errors, so it does seem related to your change.

rsandell added a commit that referenced this pull request Sep 25, 2015
Add Force Sync option to repo plugin
@rsandell rsandell merged commit b9eed66 into jenkinsci:master Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants