Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate IPv6 scoped IPs from JnlpAgentEndpointResolver.getResolvedHttpProxyAddress #769

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 17, 2024

I noticed some CloudBees CI tests failing in an IPv6 test environment (ref: BEE-52759) where InboundAgentRule.start times out because of e.g. java.lang.IllegalArgumentException: Malformed escape pair at index 22: http://0:0:0:0:0:0:0:1%lo:43723 launching the agent. I think this is because the agent is being asked to connect to a local (loopback) IP address and its proxy detection code is not written to handle general IPv6 hosts. Not tested in context. Fixes the test, it seems.

@jglick jglick added the bug For changelog: Fixes a bug. label Oct 17, 2024
@jglick jglick requested review from Vlatombe and jtnord October 17, 2024 20:41
@jglick jglick merged commit e1ea5d6 into jenkinsci:master Oct 18, 2024
14 checks passed
@jglick jglick deleted the IPv6 branch October 18, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants