Restore compatibility for older versions #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3244.vf7f977e04755 requires the agent to be upgraded in lockstep with Jenkins to avoid remoting errors such as: java.lang.IllegalStateException: Unable to call getName. No matching method found in [interface hudson.remoting.RemoteClassLoader$IClassLoader] for hudson.remoting.RemoteClassLoader$ClassLoaderProxy@2cdf8d8a[jdk.internal.loader.ClassLoaders$AppClassLoader@2cdf8d8a] This restores the compatability by specifically handling a method call to getName for the IClassLoader and returning a dummy value if the remote version is older than 3244
jtnord
force-pushed
the
restore-compatability
branch
from
e718884 to
5472f9a
Compare
14 tasks
jglick
changed the title
jglick
approved these changes
May 15, 2024
olamy
approved these changes
May 15, 2024
Vlatombe
approved these changes
May 16, 2024
|
Still draft? |
from the summary "Still to test, a newer agent.jar connecting to an older Jenkins." which I am doing atm |
|
waiting on jenkins check of jenkinsci/jenkins@e0c3211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3244.vf7f977e04755 requires the agent to be upgraded in lockstep with Jenkins to avoid remoting errors such as:
This restores the compatibility by catching the
IllegalStateExceptionwhen callingproxy.getName()and returning a dummy valueTesting done
OldRemotingAgentTestno longer fails.** validated it connected
** ran
Jenkins.class.getClassLoader().getName()in the agents script console and verified the result is expectedupgrade-remoting-to-3244.vf7f977e04755-or-higher 0x3043a782Submitter checklist