Harden JarCacheSupport
#716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implicit invariant in
JarCacheSupportis thatDownloadRunnableis only ever processing the promise that is currently recorded in theinprogressmap, an invariant which can be proved by reading the code and studying the cases that arise. This PR hardens the code by enforcing this invariant programmatically and throwing anIllegalStateExceptionif the invariant is violated, which would only be the case if a future PR introduced a programming error.Testing done
I ran a job on an inbound agent to check out a repository with JGit and verified that the new assertion was never thrown (as expected).