Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid capturing Request in LogRecord parameters #694

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Avoid capturing Request in LogRecord parameters #694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9da7b9
Avoid capturing `Request` in `LogRecord` parameters
jglick Oct 24, 2023
d3e7ac5
Can also use `Supplier` overload though it is almost purely stylistic…
jglick Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/hudson/remoting/Request.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public void run() {
// this means the caller will block forever
if (e instanceof ChannelClosedException && !logger.isLoggable(Level.FINE)) {
// TODO if this is from CloseCommand reduce level to FINE
logger.log(Level.INFO, "Failed to send back a reply to the request {0}: {1}", new Object[] {Request.this, e});
logger.info(() -> "Failed to send back a reply to the request " + Request.this + ": " + e);
} else {
logger.log(Level.WARNING, e, () -> "Failed to send back a reply to the request " + Request.this);
}
Expand Down
Loading