Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maven Shade Plugin warnings #620

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Fix Maven Shade Plugin warnings #620

merged 1 commit into from
Jan 17, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jan 17, 2023

Fixes the following Maven Shade Plugin warning

[WARNING] args4j-2.33.jar, constant-pool-scanner-1.2.jar, remoting-999999-SNAPSHOT.jar, tyrus-standalone-client-jdk-2.1.2.jar define 1 overlapping resource: 
[WARNING]   - META-INF/MANIFEST.MF

by excluding the MANIFEST.MF for any dependencies, leaving only our own. Tested by ensuring that the warning is now gone and that the MANIFEST.MF in the delivered Remoting JAR is the same before and after this PR.

@basil basil added the internal label Jan 17, 2023
@MarkEWaite MarkEWaite merged commit 8586cd9 into jenkinsci:master Jan 17, 2023
@basil basil deleted the shade branch January 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @MarkEWaite @timja