Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tyrus-standalone-client-jdk from 1.18 to 2.0.1 #477

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 3, 2021

Bumps tyrus-standalone-client-jdk from 1.17 to 2.0.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@jglick
Copy link
Member

jglick commented Sep 24, 2021

#478 is the more conservative upgrade (I guess).

Bumps tyrus-standalone-client-jdk from 1.17 to 2.0.1.

---
updated-dependencies:
- dependency-name: org.glassfish.tyrus.bundles:tyrus-standalone-client-jdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.glassfish.tyrus.bundles-tyrus-standalone-client-jdk-2.0.1 branch from f84faef to 65fe529 Compare September 24, 2021 22:06
@jglick jglick changed the title Bump tyrus-standalone-client-jdk from 1.17 to 2.0.1 Bump tyrus-standalone-client-jdk from 1.18 to 2.0.1 Sep 27, 2021
@timja
Copy link
Member

timja commented Oct 13, 2021

any reason not to ship this @jglick?

@jglick
Copy link
Member

jglick commented Oct 13, 2021

I would release #478 first. I am not entirely clear on the versioning scheme for this library.

@jeffret-b
Copy link
Contributor

In the past, I found that the 2.0.0 version didn't work with Jenkins Remoting. If someone wants to test it, we can see about taking in this newer version. (I'm low on time at the moment for that.)

Like Jesse, I haven't been able to figure out the versioning or any changelog for this library.

@jglick
Copy link
Member

jglick commented Oct 14, 2021

the 2.0.0 version didn't work with Jenkins Remoting

Interesting. Note that the compelling tests for this live in core and so would be visible only after bumping the Remoting version there, especially this.

@timja
Copy link
Member

timja commented Oct 14, 2021

jenkinsci/jenkins#5816

@timja
Copy link
Member

timja commented Oct 15, 2021

Some tests do fail, e.g. hudson.TcpSlaveAgentListenerTest.headers

Expected: is "text/plain"
     but: was "text/html"

@jglick
Copy link
Member

jglick commented Oct 15, 2021

The root error is

java.lang.ClassNotFoundException: io.jenkins.remoting.shaded.javax.websocket.ClientEndpointConfig$Configurator

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get the issues sorted out with this upgrade before merging.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 28, 2022

Superseded by #504.

@dependabot dependabot bot closed this Jan 28, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.glassfish.tyrus.bundles-tyrus-standalone-client-jdk-2.0.1 branch January 28, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants