[JENKINS-64831] Deprecate the -cp option to Launcher
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Jul 6, 2021
6 tasks
jeffret-b
approved these changes
Jul 21, 2021
jeffret-b
added
the
chore
ryancurrah
reviewed
Nov 8, 2021
| @@ -144,9 +144,10 @@ public void setTextMode(boolean b) { | |||
| public String proxyCredentials = null; | |||
|
|
|||
| @Option(name="-cp",aliases="-classpath",metaVar="PATH", | |||
| usage="add the given classpath elements to the system classloader.") | |||
| usage="add the given classpath elements to the system classloader. (DEPRECATED)") | |||
There was a problem hiding this comment.
Should this docker-inbound-agent launch script be updated to not use -cp? https://github.com/jenkinsci/docker-inbound-agent/blob/master/jenkins-agent#L121
There was a problem hiding this comment.
No, that is the --classpath / -cp option to the java launcher. This PR is about an application option, like
java -jar agent.jar -cp …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-64831