Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcode of JKS for use other key stores #435

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

gulyaev13
Copy link
Contributor

I suggest removing the hardcode with JKS Keystore to allow using other Keystores. For example, BCFKS provided in the FIPS version of Bouncy Castle.
More info here:
https://groups.google.com/g/jenkinsci-dev/c/YkEG_oSR1mw

@jeffret-b
Copy link
Contributor

At a preliminary look, this makes sense. I'll need to spend more time when I can to evaluate it.

@jeffret-b
Copy link
Contributor

Let's try a rebuild to see if we can get a clean build.

@jeffret-b jeffret-b closed this Feb 8, 2021
@jeffret-b jeffret-b reopened this Feb 8, 2021
@gulyaev13
Copy link
Contributor Author

Let's try a rebuild to see if we can get a clean build.

@jeffret-b, looks like everything is ok.

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and works fine in my limited testing.

@jeffret-b jeffret-b added enhancement For changelog: An enhancement providing new capability. ready-to-merge labels Feb 8, 2021
@jeffret-b jeffret-b merged commit ac512fb into jenkinsci:master Feb 10, 2021
@gulyaev13
Copy link
Contributor Author

@jeffret-b , do you have any plans for release 4.7 with my changes?

@jeffret-b
Copy link
Contributor

Soon. At least within a week. Probably towards the start of this coming week.

I'm not sure about when it will actually be packaged into Jenkins though. Given the changes involved in this and everything else going on in Jenkins changes at the moment, it may sit a while. This Remoting release can be used with older or existing Jenkins installations. That can enable more testing or experience with these changes, which can in turn help motivate inclusion into the Jenkins war.

@gulyaev13
Copy link
Contributor Author

Thanks for your response.
I want to use the new version of remoting for build images with the JNLP agent. It isn't related to Jenkins Core.
https://github.com/jenkinsci/docker-agent

I'm creating the same docker agent images but based on our own base image.

@jeffret-b
Copy link
Contributor

@gulyaev13 , this is now released in Remoting 4.7. I'm not going to push it into the Jenkins packaging immediately. Any testing or use results you can share will help increase confidence and speed of getting it packaged into core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For changelog: An enhancement providing new capability. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants