-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcode of JKS for use other key stores #435
Conversation
At a preliminary look, this makes sense. I'll need to spend more time when I can to evaluate it. |
Let's try a rebuild to see if we can get a clean build. |
@jeffret-b, looks like everything is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and works fine in my limited testing.
@jeffret-b , do you have any plans for release 4.7 with my changes? |
Soon. At least within a week. Probably towards the start of this coming week. I'm not sure about when it will actually be packaged into Jenkins though. Given the changes involved in this and everything else going on in Jenkins changes at the moment, it may sit a while. This Remoting release can be used with older or existing Jenkins installations. That can enable more testing or experience with these changes, which can in turn help motivate inclusion into the Jenkins war. |
Thanks for your response. I'm creating the same docker agent images but based on our own base image. |
@gulyaev13 , this is now released in Remoting 4.7. I'm not going to push it into the Jenkins packaging immediately. Any testing or use results you can share will help increase confidence and speed of getting it packaged into core. |
I suggest removing the hardcode with JKS Keystore to allow using other Keystores. For example, BCFKS provided in the FIPS version of Bouncy Castle.
More info here:
https://groups.google.com/g/jenkinsci-dev/c/YkEG_oSR1mw