Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacktoberfest] Code cleanup #413

Merged
merged 20 commits into from
Oct 16, 2020
Merged

[Hacktoberfest] Code cleanup #413

merged 20 commits into from
Oct 16, 2020

Conversation

basil
Copy link
Member

@basil basil commented Oct 15, 2020

A series of code cleanup changes for this repository. Most of these changes remove usages of deprecated functionality or otherwise fix IDE warnings. I kept each commit separate. Each commit message should be self-explanatory, but if anything is unclear I am happy to provide further explanation. Also, feel free to revert any specific cleanup commits that are unwanted.

Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for the cleanup.

I'll add this to the release I'm trying to get out soon.

@jeffret-b jeffret-b added chore For changelog: A maintenance chore with no functional changes ready-to-merge labels Oct 15, 2020
@jeffret-b jeffret-b merged commit a3e37a2 into jenkinsci:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For changelog: A maintenance chore with no functional changes ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants