Minor JNLP parsing improving, mostly in testing #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't process meaningless arguments. A few simple tests for XXE, etc., during jnlp processing.
The result is essentially the same, but this form is a little clearer and more thorough.
jeffret-b
added
the
chore
jvz
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was improved during findsecbugs processing. Now that I've dug into it a little bit I'm adding some minor improvements. The findsecbugs documentation suggests two feature settings to resolve the issue. They both yield essentially the same result. This one is a little cleaner and more thorough.
Mostly, this change involves adding several tests to demonstrate the processing behavior. These aren't essential but they are good documentation.