Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javax.websocket to pom.xml #366

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 22, 2020

IntelliJ configured to use adoptopenjdk openj9 1.8 complains about:

import javax.websocket.ClientEndpointConfig;
import javax.websocket.CloseReason;
import javax.websocket.ContainerProvider;
import javax.websocket.Endpoint;
import javax.websocket.EndpointConfig;
import javax.websocket.HandshakeResponse;
import javax.websocket.Session;

This appears to make it happy.

@jeffret-b jeffret-b requested a review from jvz January 27, 2020 18:54
Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work fine. I'm a little concerned about adding a dependency if it isn't needed but I don't see how it causes a problem either. I've played around with testing it a little and don't see that this changes anything. It does make more sense that it be listed as a dependency as it is imported.

pom.xml Show resolved Hide resolved
@jeffret-b
Copy link
Contributor

I'm not sure that makes a real difference but that's better to specify the scope.

@jeffret-b jeffret-b added chore For changelog: A maintenance chore with no functional changes ready-to-merge labels Jan 27, 2020
@jeffret-b jeffret-b merged commit 207af91 into jenkinsci:master Feb 6, 2020
@jsoref jsoref deleted the pom-javax-websocket branch February 6, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For changelog: A maintenance chore with no functional changes ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants