Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Chinese as server name #240

Closed
liuweiGL opened this issue Mar 21, 2022 · 11 comments · Fixed by #266
Closed

Can't use Chinese as server name #240

liuweiGL opened this issue Mar 21, 2022 · 11 comments · Fixed by #266
Labels

Comments

@liuweiGL
Copy link
Contributor

Jenkins and plugins versions report

Environment
Jenkins: 2.332.1
OS: Linux - 5.4.0-58-generic
---
publish-over:0.22
publish-over-ssh:1.24

What Operating System are you using (both controller, and any agents involved in the problem)?

Windows 10

Reproduction steps

Configure the SSH Servers

Expected Results

Showing original Chinese name:

image

Actual Results

Chinese is escaped to Unicode:

image

Anything else?

Why this is necessary:

cdfeea7

@liuweiGL liuweiGL added the bug label Mar 21, 2022
@yangweijie
Copy link

same

@liuweiGL liuweiGL changed the title Can't use chinese as server name Can't use Chinese as server name Mar 22, 2022
@Jmingzi
Copy link

Jmingzi commented Apr 19, 2022

pr 文件修改,取名字的时候应该 unescape 才对。
降级到 1.23 吧。

@gmcdonald
Copy link
Contributor

@liuweiGL - Are you saying this is a regression introduced in cdfeea7 ?

@liuweiGL
Copy link
Contributor Author

yes

@derline
Copy link

derline commented Jun 22, 2022

same. This is a bug for Chinese characters.

@gmcdonald
Copy link
Contributor

@olamy can you look into this, apparantly your removal of some loc at https://github.com/jenkinsci/publish-over-ssh-plugin/pull/61/files has caused this.

@derline
Copy link

derline commented Jul 20, 2022

@olamy Please!

liuweiGL added a commit to liuweiGL/publish-over-ssh-plugin that referenced this issue Aug 28, 2022
@liunancun
Copy link

liunancun commented Aug 4, 2023

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

@derline
Copy link

derline commented Aug 4, 2023

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

准备找 jenkins 替代品吧,它太老了。

@derline
Copy link

derline commented Aug 4, 2023

我已经放弃这家伙了

@olamy
Copy link
Member

olamy commented Aug 4, 2023

@liuweiGL hi, Can this fix be compiled separately for a version of jdk8? Jenkins version 2.346.3 cannot install version 1.25 of this.

@liunancun 2.346.3 is old now and suffers from few security issues. Maybe you should have a look at upgrading your Jenkins version? The minimum required now is 2.361.4
Does something prevent you from upgrading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants