Add phase to animal-sniffer to fix mvn test

[timja]

Without this change I couldn't run mvn test in the https://github.com/jenkinsci/configuration-as-code-plugin

The error was:

animal-sniffer-maven-plugin:1.17:check: java.lang.NoSuchMethodError: java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;

the documentation says to use test https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/usage.html

cc @oleg-nenashev @sladyn98 @Casz

[sladyn98]

One of the fixes suggested on a forum was to use v 1.18 but that didn't work either. This should sort it

[oleg-nenashev]

Fine with me

[olamy]

LGTM maybe upgrade to last version of the plugin as well?
and add a comment TODO to remove this and use --release when using java9+ :) (maybe we could have some profile for that? but it's a bigger change..)

[oleg-nenashev]

LGTM maybe upgrade to last version of the plugin as well?

Are there newer ones? Dependabot should have proposed them

and add a comment TODO to remove this and use --release when using java9+ :) (maybe we could have some profile for that? but it's a bigger change..)

Ongoing work in #133 . I moved on to other stories due to the priority change, but it can be finalized.

[olamy]

1.18 release date is 2019-05-12

[jglick]

What was the problem here—why was only this plugin affected?

[sladyn98]

I am not quite sure but seems like version 1.17 was not compatible with java 8.

[oleg-nenashev]

FTR #200 . Dependabot said "Looks like these dependencies are up-to-date now, so this is no longer needed.". It is a follow-up to the #229 revert last week which updated the Animal Sniffer. The Dependabot just has not resubmitted the PR yet

[timja]

What was the problem here—why was only this plugin affected?

mvn install worked but mvn test didn't, I was specifically trying to reproduce an issue which didn't occur when running in intellij but was unable to run a single test

(error is in PR description)

[jglick]

So this is thought to be a regression from a dependency update? Needs an IT.

[oleg-nenashev]

Merge it anyway? Just would like to cut a new release to reintroduce BOM

[oleg-nenashev]

One of the fixes suggested on a forum was to use v 1.18 but that didn't work either. This should sort it

1.18 just got merged in #257 . If the problem persists after it, i will cut a release for this fix also

[timja]

One of the fixes suggested on a forum was to use v 1.18 but that didn't work either. This should sort it

1.18 just got merged in #257 . If the problem persists after it, i will cut a release for this fix also

the problem is there with both versions, I tested upgrading when I was troubleshooting and it didn't help any without this fix

[oleg-nenashev]

OK, let's merge it then