Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for JDK-8212233 is not a workaround, it should have been done anyway #196

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 30, 2019

As per #173 (comment). Despite JDK-8219474 claiming some fix was backported to 11.0.3, it is still reproducible in the AdoptOpenJDK build at least:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:jar (attach-javadocs) on project workflow-durable-task-step: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] …/jenkinsci/workflow-durable-task-step-plugin/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java:374: warning: no @throws for java.io.IOException
[ERROR]         public @CheckForNull FlowNode getNode() throws IOException, InterruptedException {
[ERROR]                                       ^
[ERROR] …/jenkinsci/workflow-durable-task-step-plugin/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java:374: warning: no @throws for java.lang.InterruptedException
[ERROR]         public @CheckForNull FlowNode getNode() throws IOException, InterruptedException {
[ERROR]                                       ^
[ERROR] 
[ERROR] Command line was: …/jdk-11.0.3+7/bin/javadoc @options @packages

jglick added a commit to jglick/workflow-durable-task-step-plugin that referenced this pull request Apr 30, 2019
@jglick
Copy link
Member Author

jglick commented Apr 30, 2019

And IIUC the JDK 11 on ci.jenkins.io got bumped up to 11.0.3 as part of INFRA-2086, breaking #173 suddenly. As I noted to @olblak in that issue, this is why I find it awful to have some unknown tool version injected into my build: it means my unrelated PRs (in this case jenkinsci/workflow-durable-task-step-plugin#104) fail with a cryptic error which I have to drop everything and fix, rather than being able to deal with the problem in a leisurely fashion via @dependabot.

@jglick jglick merged commit 33dabde into jenkinsci:master Apr 30, 2019
@jglick jglick deleted the JDK-8212233 branch April 30, 2019 21:26
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants