Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit spotbugs CT_CONSTRUCTOR_THROWS visitor #1242

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Omit spotbugs CT_CONSTRUCTOR_THROWS visitor #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@
<!-- https://github.com/jenkinsci/plugin-pom/pull/869 -->
<spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
<spotbugs.effort>Max</spotbugs.effort>
<!-- TODO: Remove when plugin pom includes this omitVisitors -->
<!-- https://github.com/jenkinsci/plugin-pom/pull/869 -->
<spotbugs.omitVisitors>ConstructorThrow,FindReturnRef</spotbugs.omitVisitors>
<spotbugs.threshold>Low</spotbugs.threshold>
<spotless.check.skip>false</spotless.check.skip>
</properties>
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/jvnet/hudson/plugins/platformlabeler/LsbRelease.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
package org.jvnet.hudson.plugins.platformlabeler;

import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileInputStream;
Expand Down Expand Up @@ -81,7 +80,6 @@ public LsbRelease() {
}

/** Read file to assign distributor ID and release. Package protected for tests. */
@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Finalizer attack not viable")
LsbRelease(@NonNull File lsbReleaseFile) throws IOException {
Map<String, String> newProps = new HashMap<>();
try (FileInputStream stream = new FileInputStream(lsbReleaseFile)) {
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/jvnet/hudson/plugins/platformlabeler/WindowsRelease.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
package org.jvnet.hudson.plugins.platformlabeler;

import edu.umd.cs.findbugs.annotations.NonNull;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.io.BufferedReader;
import java.io.File;
import java.io.FileInputStream;
Expand Down Expand Up @@ -64,7 +63,6 @@ public WindowsRelease() {
}

/** Read file to assign distributor ID and release. Package protected for tests. */
@SuppressFBWarnings(value = "CT_CONSTRUCTOR_THROW", justification = "Finalizer attack not viable")
WindowsRelease(File windowsReleaseFile) throws IOException {
Map<String, String> newProps = new HashMap<>();
try (FileInputStream stream = new FileInputStream(windowsReleaseFile)) {
Expand Down