Deleting concurrency parameter to deprecated non-block-scoped variant of stage step
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jglick
added a commit
to jglick/blueocean-plugin
that referenced
this pull request
Jan 18, 2023
This comment was marked as resolved.
This comment was marked as resolved.
jglick
commented
Jan 18, 2023
src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java
Show resolved
Hide resolved
jglick
commented
Jan 18, 2023
src/main/java/org/jenkinsci/plugins/workflow/support/steps/StageStepExecution.java
Show resolved
Hide resolved
This was referenced Jan 18, 2023
Merged
raul-arabaolaza
approved these changes
Jan 19, 2023
This comment was marked as resolved.
This comment was marked as resolved.
rsandell
approved these changes
Jan 19, 2023
Member
rsandell
left a comment
rsandell
left a comment
There was a problem hiding this comment.
Oh how lovely to see code being removed! :D
car-roll
approved these changes
Jan 19, 2023
…tempts to use `concurrency` jenkinsci#94 (comment)
jglick
changed the title
stage stepconcurrency parameter to deprecated non-block-scoped variant of stage step
dwnusbaum
approved these changes
Jan 20, 2023
rsandell
approved these changes
Jan 23, 2023
Member
Author
|
Doing some final PCT testing, then will likely release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #5, more than six years ago, the old non-block-scoped mode was deprecated. It is time to finally delete the rather complex code to support its
concurrencyparameter (~ gating stages), which no one should still be using (superseded bylock+milestone). The tests were flaky and required maintenance, like in #70.Can also check for obsolete issues in https://issues.jenkins.io/issues/?jql=resolution%20%3D%20Unresolved%20and%20component%20%3D%20pipeline-stage-step-plugin%20