Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assumption that configured agents are online #531

Merged
merged 1 commit into from
May 25, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented May 24, 2022

#462 (arguably) made sense at the time. Yet after #527, the effect was that a lot of tests (e.g., LibrariesTest) started being skipped all the time.

@jglick jglick added the tests label May 24, 2022
@jglick jglick requested review from timja, jtnord, car-roll and olamy May 24, 2022 23:24
@jglick
Copy link
Member Author

jglick commented May 24, 2022

(I shudder to think how slow and flaky the Windows CI branch will be now.)

@timja
Copy link
Member

timja commented May 25, 2022

(I shudder to think how slow and flaky the Windows CI branch will be now.)

1h08 apparently, twice the time as linux. About 20-25 mins slower than the master branch

@jtnord jtnord merged commit 12b420f into jenkinsci:master May 25, 2022
@jglick
Copy link
Member Author

jglick commented May 25, 2022

https://ci.jenkins.io/job/Plugins/job/pipeline-model-definition-plugin/job/master/buildTimeTrend 47m → 73m 😢 (as usual Windows CI is the bottleneck)

@jglick jglick deleted the assume-online branch May 25, 2022 12:20
jglick added a commit to jglick/bom that referenced this pull request May 25, 2022
jglick added a commit to jenkinsci/bom that referenced this pull request May 26, 2022
* Add `pipeline-groovy-lib`; remove 2.289.x line

* Removing some forgotten mentions of 2.289.x

* jenkinsci/pipeline-model-definition-plugin#531 released

* Put 2.289.x back in

* Add `pipeline-groovy-lib` to `test` scope in `sample-plugin`

* Pick up jenkinsci/workflow-multibranch-plugin#180 & jenkinsci/workflow-multibranch-plugin#181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants