Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCT compat with Jenkins 2.320 #463

Merged
merged 2 commits into from
Nov 17, 2021
Merged

PCT compat with Jenkins 2.320 #463

merged 2 commits into from
Nov 17, 2021

Conversation

timja
Copy link
Member

@timja timja commented Nov 16, 2021 •
edited
Loading

@timja timja requested a review from a team November 16, 2021 20:47
jglick
jglick approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just increase jenkins.version to minimize complexity in the test.

@timja
Copy link
Member Author

timja commented Nov 17, 2021

Build is green now @car-roll

@jglick jglick mentioned this pull request Nov 17, 2021
Merged
@car-roll car-roll added the tests label Nov 17, 2021
@car-roll car-roll merged commit 01e8d67 into jenkinsci:master Nov 17, 2021
@timja timja deleted the compat-with-jenkins-2.320 branch November 17, 2021 14:32
@timja
Copy link
Member Author

timja commented Nov 17, 2021

Would you be able to release it please?

@jglick
Copy link
Member

jglick commented Nov 17, 2021 •
edited
Loading

Note that even without #464 or a release you should be able to test this in PCT via the merge commit 01e8d67 (assuming that passes).

@timja
Copy link
Member Author

timja commented Nov 17, 2021

Yes I'm planning to, build is super slow in this repo though.
Windows takes 50min + 😢

Linux is ~20min

@jglick
Copy link
Member

jglick commented Nov 17, 2021

Interesting. @jtnord and others noticed that ZIP expansion (used heavily by RealJenkinsRule unpacking plugins) is much slower on Windows than on Linux on the same hardware.

@jtnord
Copy link
Member

jtnord commented Nov 17, 2021

Interesting. @jtnord and others noticed that ZIP expansion (used heavily by RealJenkinsRule unpacking plugins) is much slower on Windows than on Linux on the same hardware.

microsoft/java-wdb#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@jglick jglick jglick approved these changes

@car-roll car-roll car-roll approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timja @jglick @jtnord @basil @car-roll