Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

Require Jenkins 2.479.1 and Jakarta EE 9

Jenkins 2.479.1 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.

  • Update plugin pom and baseline
  • Remove deprecations
  • Use Java 17 language features
  • Minor cleanup

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner February 21, 2025 10:34
@jglick
Copy link
Member

jglick commented Feb 28, 2025

@strangelookingnerd when you force-push to a nontrivial PR, it resets GH’s counter of the last-reviewed commit and forces any reviewer to start from scratch. Better IMO to just push a simple follow-on commit. The maintainer can choose to either merge or squash.

@jglick
Copy link
Member

jglick commented Feb 28, 2025

(remember you can accept suggested edits in batch rather than one commit per)

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick jglick merged commit 3b9c4ae into jenkinsci:master Feb 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants