Skip to content

Conversation

@gounthar
Copy link
Contributor

@gounthar gounthar commented Oct 3, 2023

Test with Java 21

Java 21 was released Sep 19, 2023. We want to announce full support for Java 21 in early October and would like the most used plugins to be compiled and tested with Java 21.

The acceptance test harness and plugin bill of materials tests are already passing with Java 21. This is a further step to improve plugin readiness for use with Java 21 and for development with Java 21.

The change intentionally tests only two Java configurations, Java 17 and Java 21 because we believe that the risk of a regression that only affects Java 11 is shallow. We generate Java 11 byte code with the Java 17 and the Java 21 builds, so we're already testing Java 11 byte code.

Testing done

Confirmed tests pass with Java 21 after upgrading to a recent parent POM and to Jenkins version 2.361.4 as the minimum version.

@gounthar
Copy link
Contributor Author

gounthar commented Oct 3, 2023

We're still using JDK8, and that's why the build is failing.
Could someone please re-run it with our proposed Jenkinsfile?
Thanks.

@basil
Copy link
Member

basil commented Oct 3, 2023

https://ci.jenkins.io/job/Plugins/job/pipeline-graph-analysis-plugin/job/PR-121/2/

@gounthar
Copy link
Contributor Author

gounthar commented Oct 4, 2023

Thank you, Basil.
Unfortunately, JDK17 failed. I'll test it on my machine.

@gounthar
Copy link
Contributor Author

gounthar commented Oct 4, 2023

JDK17 works on my machine. 🤔
The error on Jenkins build for Windows/JDK17 seems to be:
java.nio.file.FileSystemException: C:\Jenkins\agent\workspace\ine-graph-analysis-plugin_PR-121\target\tmp\j h9526074380145415386\jobs\Fails\builds\1\log: The process cannot access the file because it is being used by another process

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix for plugin bom version

@gounthar
Copy link
Contributor Author

gounthar commented Oct 9, 2023

Thank you, Mark.

@jglick jglick mentioned this pull request Feb 27, 2024
@gounthar gounthar requested a review from a team as a code owner February 27, 2024 19:20
@jglick jglick merged commit 9e2bcc8 into jenkinsci:master Feb 27, 2024
@gounthar gounthar deleted the jdk21 branch February 28, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants