Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Oct 9, 2021

This change was reverted in elastic/elasticsearch#40828

It works fine on Java 11+

It prevents the demo from working on arm64 such as mac m1

@timja timja requested a review from kuisathaverat as a code owner October 9, 2021 17:58
@kuisathaverat kuisathaverat added the bug Something isn't working label Oct 10, 2021
@timja
Copy link
Member Author

timja commented Oct 10, 2021

FTR once you rebuild the open telemetry contrib image with the dockerfile from open-telemetry/opentelemetry-collector-contrib#2379 (comment) this works on ARM64

@cyrille-leclerc
Copy link
Contributor

Thanks @timja , I'll defer to @kuisathaverat and @v1v for the review

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@v1v
Copy link
Member

v1v commented Oct 11, 2021

FTR once you rebuild the open telemetry contrib image with the dockerfile from open-telemetry/opentelemetry-collector-contrib#2379 (comment) this works on ARM64

I'd say to wait for the new docker image to be officially published. Or maybe add a comment in the README.md to highlight that it's supported by using those instructions. WDYT?

@timja
Copy link
Member Author

timja commented Oct 11, 2021

I'd say to wait for the new docker image to be officially published. Or maybe add a comment in the README.md to highlight that it's supported by using those instructions. WDYT?

The request was raised 7 months ago and there's been a PR open for awhile as well... (so I wouldn't say wait 😂 )

Worth adding the workaround to readme yes

@v1v v1v merged commit 100a7aa into master Oct 11, 2021
@cyrille-leclerc cyrille-leclerc deleted the remove-use-avx branch December 20, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants