Upgrade to v3.14.9 and remove okhttp3 url-connection

[bitwiseman]

I've published an initial v3.12.12 with the url-connection still included.

This updates to the latest v3.14, which does not have url-connection any more.

Note: okhttp 2.7.5 urlconnection is retained as that is much more widely used.

[bitwiseman]

Also, we discussed pulling ObsoleteUrlFactory.java into this plugin. That would make it the responsibility of this plugin to maintain that obsolete API for use.

[dwnusbaum]

It's hard to evaluate this without seeing PRs to other plugins currently using OkHttp to understand whether this would affect them being able to use the API plugin. Can we get draft PRs filed for downstream plugins to understand the impact?

[bitwiseman]

The move to a version of okhttp3 that does not support HttpUrlConnection should only effect plugins that depend that feature (or have transitive dependencies on it). Kubernetes client doesn't depend on it:

https://github.com/fabric8io/kubernetes-client/blob/2ed58668ab6a0f83e038844d96efbbf4eea92a9c/kubernetes-client/pom.xml#L126-L134

The version change may still have some effect. I'll need to create script of some sort to go looking for okhttp3 in the transitive dependencies of jenkins plugins.

[bitwiseman]

@dwnusbaum

Summary

To summarize our offline discussion and my analysis:

The github-api-plugin is the only current consumer of this plugin. Thus the main concern in updating this plugin to a version that does not support okhttp3.okhttp-urlconnection would be the following scenario:

• another plugin depends on github-api-plugin AND
• that plugin (or some plugin that depends on it) also requires okhttp3.okhttp-urlconnection

I've done analysis on the dependencies and this appears safe.

Details

Only the following plugins depend on github-api-plugin:

DotCi
blueocean-github-pipeline
elasticbox
ghprb
github
github-branch-source
github-coverage-reporter
github-issues
github-oauth
github-pr-coverage-status
github-pullrequest
ignore-committer-strategy
multibranch-build-strategy-extension
multibranch-scan-webhook-trigger
pipeline-githubnotify-step

okhttp3.okhttp-urlconnection

These are the only plugins that bundle okhttp3.okhttp-urlconnection and their dependencies:

azure-acs
+-- azure-commons
+-- azure-credentials
+-- kubernetes-cd
    +-- azure-commons
    +-- azure-credentials
    +-- credentials
    +-- credentials-binding
    +-- docker-commons
    +-- ssh-credentials

azure-ad
+-- azure-commons
+-- cloudbees-folder
+-- configuration-as-code
+-- matrix-auth

azure-app-service
+-- azure-commons
+-- azure-credentials
+-- docker-commons
+-- docker-java-api
+-- git-client

azure-batch-parallel

azure-commons
+-- jackson2-api
+-- ssh-credentials
+-- worflow-step-api

azure-container-agents
+-- azure-commons
+-- azure-credentials
+-- docker-commons
+-- plain-credentials
+-- ssh-credentials
+-- windows-azure-storage

azure-container-registry-tasks
+-- azure-commons
+-- azure-credentials
+-- scm-api
+-- structs

azure-credentials
+-- credentials
+-- credentials-binding
+-- jackson2-api
+-- plain-credentials
+-- ssh-credentials
+-- structs

azure-function
+-- azure-app-service
+-- azure-commons
+-- azure-credentials
+-- git-client

azure-iot-edge
+-- azure-commons
+-- azure-credentials
+-- docker-commons

azure-vm-agents
+-- azure-commons
+-- azure-credentials
+-- azure-commons
+-- cloud-stats
+---credentials
+---plain-credentials

azure-vmss
+---azure-commons
+---azure-credentials

service-fabric
+---azure-commons
+---azure-credentials
+---structs
+---workflow-durable-task-step

upload-pgyer
+-- structs

None of the plugins that currently bundle okhttp3.okhttp-urlconnection depend (directly or transitively) on github-api-plugin. This change is safe.

[dwnusbaum]

Changes and doc updates look good to me. It would be great to see a linked PR to github-api to test the change.

[bitwiseman]

Linked PR showing this working - jenkinsci/github-api-plugin#57