-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71737] make MesosCloud name uneditable #420
Conversation
Does not look like incrementals is working, may need to way for release |
@@ -145,6 +145,11 @@ public MesosCloud( | |||
this.master); | |||
} | |||
|
|||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just comment this out with a TODO and merge the PR whenever doesn't need to be dependent on the core PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out with a TODO in 73d45ab
The Gradle ecosystem only supported incrementals in the last few months and this plugin hasn't been updated for a couple of years |
@timja, do you have merge permissions to this repository? I do not |
No I am not a maintainer here |
cc @jeschkies for review |
moving to draft and waiting for a non-incremental version to bump this PR to |
downstream of jenkinsci/jenkins#8310
Setting
MesosCloud.isNameEditable()
tofalse
. This will disable the cloud rename page.Testing done
Submitter checklist