Fixing JENKINS-48867 - Prevent multi branch projects from orphaning items if repository is unavailable #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tems if repository is unavailable
jglick
reviewed
Oct 13, 2020
| @@ -195,22 +195,19 @@ public void setCredentialsId(@CheckForNull String credentialsId) { | |||
| .newRequest(this, listener) ) { | |||
| MercurialInstallation inst = MercurialSCM.findInstallation(request.installation()); | |||
| if (inst == null) { | |||
| listener.error("No configured Mercurial installation"); | |||
| return; | |||
| throw new IOException("No configured Mercurial installation"); | |||
There was a problem hiding this comment.
Suggested change
| throw new IOException("No configured Mercurial installation"); | |
| throw new AbortException("No configured Mercurial installation"); |
and similarly elsewhere.
|
Could probably be reproduced in |
|
See #149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing JENKINS-48867 using the suggestion by Dave E
I don't know if this will break expected behaviour in other use cases but it seems to fix this issue.