Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #143

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@daniel-beck
Copy link
Member

Is this another thing that's blocking someone else but nobody bothers to say so, or can I do this whenever is convenient?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jun 26, 2023

Is this another thing that's blocking someone else but nobody bothers to say so, or can I do this whenever is convenient?

I'm not aware of this change being a blocker for anyone else. The blocking changes that were detected by the plugin bill of materials were all included in plugin BOM 2193 that released two weeks ago. Based on the list of plugins that depend on this plugin, I don't see anything that hints it is a blocker for any other work.

@daniel-beck daniel-beck merged commit 4444fa9 into jenkinsci:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants