Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump parent pom #138

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Bump parent pom #138

merged 1 commit into from
Apr 18, 2023

Conversation

timja
Copy link
Member

@timja timja commented Apr 18, 2023

@timja timja requested a review from daniel-beck April 18, 2023 07:51
@daniel-beck
Copy link
Member

daniel-beck commented Apr 18, 2023

I considered that as an addition to #135, but the generated pom.xml looked weird to me. Do you understand why the dependency on jenkins-core is gone (new in 4.57)?

@timja
Copy link
Member Author

timja commented Apr 18, 2023

I considered that as an addition to #135, but the generated pom.xml looked weird to me. Do you understand why the dependency on jenkins-core is gone (new in 4.57)?

Unsure is it causing any issues?

A bunch of maven plugins were updated in 4.57: https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.57

@daniel-beck
Copy link
Member

Unsure is it causing any issues?

I don't know, I'm not using matrix-auth as a dependency, where the pom would matter.

@timja
Copy link
Member Author

timja commented Apr 18, 2023

Unsure is it causing any issues?

I don't know, I'm not using matrix-auth as a dependency, where the pom would matter.

I tested it here with no issues: jenkinsci/azure-ad-plugin#401

@daniel-beck daniel-beck merged commit f083989 into jenkinsci:master Apr 18, 2023
@timja timja deleted the bump-parent-pom branch April 18, 2023 14:36
@basil
Copy link
Member

basil commented Apr 18, 2023

I considered that as an addition to #135, but the generated pom.xml looked weird to me. Do you understand why the dependency on jenkins-core is gone (new in 4.57)?

I assume you mean this:

@@ -43,34 +42,10 @@
       <optional>true</optional>
     </dependency>
-    <dependency>
-      <groupId>org.jenkins-ci.main</groupId>
-      <artifactId>jenkins-core</artifactId>
-      <version>2.361.4</version>
-      <scope>provided</scope>
-      <exclusions>
-        <exclusion>
-          <artifactId>servlet-api</artifactId>
-          <groupId>javax.servlet</groupId>
-        </exclusion>
-      </exclusions>
-    </dependency>
-    <dependency>
-      <groupId>javax.servlet</groupId>
-      <artifactId>javax.servlet-api</artifactId>
-      <version>3.1.0</version>
-      <scope>provided</scope>
-    </dependency>
-    <dependency>
-      <groupId>commons-logging</groupId>
-      <artifactId>commons-logging</artifactId>
-      <version>1.2</version>
-      <scope>provided</scope>
-    </dependency>
   </dependencies>
   <repositories>
     <repository>

I assume one of the changes in https://github.com/mojohaus/flatten-maven-plugin/releases/tag/1.4.0 caused this, not sure which one. But that was a fairly significant release of Flatten Maven Plugin with a lot of cleanup so I am not surprised. In any case I think the change is desirable and an improvement rather than a bug. The "BOM" profile we use in Flatten Maven Plugin is designed to strip any unnecessary elements, and these are certainly unnecessary since they are not used at runtime. Besides which, as @timja noted, if plugin POM 4.57 really was causing problems we would likely have noticed it by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants