Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nav-tabs in the resources page #449

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

mPokornyETM
Copy link
Contributor

@mPokornyETM mPokornyETM commented Jan 25, 2023

When you use many resources and many labels, the page /lockable-resources/ might have a long content. Scroll down after every refresh to see labels-status is not very user friendly.

This PR will provide a view in nav-tabs. It is also prepared for futured tabs like log and queues.

image

Many thx to Vandit Singh @Vandit1604

Testing done

Just few manual tests.
Used Jenkins 2.361.4

Proposed upgrade guidelines

N/A

Localizations

  • English
    Other localizations shall be provide by Crowdin

Submitter checklist

  • [ ] The Jira / Github issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • The changelog generator for plugins uses the pull request title as the changelog entry.
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • Any localizations are transferred to *.properties files.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically. See also release-drafter-labels.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • java code changes are tested by automated test.

@mPokornyETM mPokornyETM requested a review from a team as a code owner January 25, 2023 23:12
@mPokornyETM mPokornyETM added enhancement ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.) localization labels Jan 25, 2023
@mPokornyETM mPokornyETM enabled auto-merge (squash) January 25, 2023 23:24
@mPokornyETM
Copy link
Contributor Author

@g3n35i5 or @mark-reiche maybe you can review this changes

@mark-reiche
Copy link

@mPokornyETM reviewed the change and tested it manually here. Looks good to me.

@mPokornyETM mPokornyETM disabled auto-merge January 27, 2023 08:26
@mPokornyETM mPokornyETM merged commit 157231b into jenkinsci:master Jan 27, 2023
@chickenkiller
Copy link

very nice ! Thank you, great improvement!

@mPokornyETM mPokornyETM deleted the use-tab-views branch January 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement localization ui Features that may impact UI, pages made by the plugin or external UIs (BO, legacy, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants