refactor: Java Security Ultimate Scan 2023

src/main/java/org/apache/commons/httpclient/methods/multipart/MultipartRequestEntity.java

@@ -31,6 +31,7 @@
 
 import java.io.IOException;
 import java.io.OutputStream;
+import java.security.SecureRandom;
 import java.util.Random;
 
 import org.apache.commons.httpclient.methods.RequestEntity;
@@ -99,7 +100,7 @@ public class MultipartRequestEntity implements RequestEntity {
      * @return
      */
     private static byte[] generateMultipartBoundary() {
-        Random rand = new Random();
+        Random rand = new SecureRandom();
         byte[] bytes = new byte[rand.nextInt(11) + 30]; // a random size from 30 to 40
         for (int i = 0; i < bytes.length; i++) {
             bytes[i] = MULTIPART_CHARS[rand.nextInt(MULTIPART_CHARS.length)];

src/test/java/org/apache/commons/httpclient/TestPartsNoHost.java

@@ -36,6 +36,7 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.io.PrintWriter;
+import java.nio.file.Files;
 
 import junit.framework.Test;
 import junit.framework.TestCase;
@@ -109,7 +110,7 @@ public void testFilePartNullFileResendsData() throws Exception {
      * written to.
      */
     private File createTempTestFile() throws IOException {
-        File file = File.createTempFile("FilePartTest", ".txt");
+        File file = Files.createTempFile("FilePartTest", ".txt").toFile();
         PrintWriter out = new PrintWriter(new FileWriter(file));
         out.println(PART_DATA);
         out.flush();