Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #240

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

timja-bot
Copy link
Contributor

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot requested a review from a team as a code owner June 6, 2023 07:21
@timja
Copy link
Member

timja commented Jun 6, 2023

🚢 ?

@alecharp alecharp merged commit 9f90b92 into jenkinsci:master Jun 6, 2023
@alecharp
Copy link
Member

alecharp commented Jun 6, 2023

@timja generally, those pull requests should be released because of BOM / PCT?

@timja
Copy link
Member

timja commented Jun 6, 2023

@timja generally, those pull requests should be released because of BOM / PCT?

not needed currently as there's no known features that require it.
Sometimes these would need releasing if we're trying to use JavaScript that HtmlUnit only supports in newer versions.

Just trying to do an eco-system wide migration (https://docs.google.com/spreadsheets/d/1ih_gVd9uhxLw4BZ6IeJGrYsvu-DvIF0xovu4wZbaXy8/edit#gid=0)

@alecharp
Copy link
Member

alecharp commented Jun 6, 2023

Perfect. Was just wondering if this migration required a release this time.
Thank you for your answer (and those PR).

@basil
Copy link
Member

basil commented Aug 3, 2023

Can this please be released? This will allow me to do some plugin compatibility tester (PCT) experiments with a newer version of the Jenkins test harness (JTH).

@olamy olamy added the developer label Aug 9, 2023
@olamy
Copy link
Member

olamy commented Aug 9, 2023

Can this please be released? This will allow me to do some plugin compatibility tester (PCT) experiments with a newer version of the Jenkins test harness (JTH).

I wish I could do it manually...
I added a label and re-run CD but it didn't turn into a release...
So I gave up sorry.

@olamy
Copy link
Member

olamy commented Aug 9, 2023

I even added the enhancement label but still no release.

Screenshot from 2023-08-09 15-38-47

so good luck

@jonesbusy
Copy link

You just need to wait for the master branch to finish building.

master_branch_building

@jonesbusy
Copy link

@olamy
Copy link
Member

olamy commented Aug 9, 2023

Good to hear.
Sorry I'm Jenkins Developer not GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants