Bugfix/jenkins 64121

[obegron]

Fixes issue with importing jobs in folders
https://issues.jenkins.io/browse/JENKINS-64121
https://issues.jenkins.io/browse/JENKINS-53902
Creates the folders before creating jobs in folders using parent item instead of full path.
I removed the links to the jobs after completed import as it only linked to the job name without the folders so they would point wrong.

[ianwilliams1]

It would seem the test case data structure previously included folders and I assume all the tests "PASSSED", yet it failed to work in the real world. Do the test cases need to be augmented or changed to 1) cover the breaking / fix scenario, 2) ensure it does not break again? DO we need more test cases ?
ie:

• Import jobs in a folder to root
• Import jobs in a folder to a non-existent but same structure
• Import jobs into folder where folder already exists (but job does not)
• Import the folder job no jobs in the folder (not sure why someone would do that, but allowed)
• Recursively Import jobs in folders

[obegron]

@ianwilliams1 You are right, when changed the String concat -> stringBuffer I choose the wrong constant (obegron@d092711), I'm also surprised that it did not get caught by the current tests. Thanks for verifying

[pmyakishev]

Hi @obegron, by any chance u can post/include hpi file? I really doubt that your fix will be merged to the master.
thank you for fixing it!

[obegron]

You can get it here https://ci.jenkins.io/job/plugins/job/job-import-plugin/view/change-requests/job/PR-31/2/Sent from my Galaxy -------- Original message --------From: pmyakishev ***@***.***> Date: 26/01/2022 02:10 (GMT+08:00) To: jenkinsci/job-import-plugin ***@***.***> Cc: obegron ***@***.***>, Mention ***@***.***> Subject: Re: [jenkinsci/job-import-plugin] Bugfix/jenkins 64121 (PR #31) Hi @obegron, by any chance u can post/include hpi file? I really doubt that your fix will be merged to the master. thank you for fixing it! —Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***>

[pmyakishev]

You can get it here https://ci.jenkins.io/job/plugins/job/job-import-plugin/view/change-requests/job/PR-31/2/Sent from my Galaxy -------- Original message --------From: pmyakishev @.> Date: 26/01/2022 02:10 (GMT+08:00) To: jenkinsci/job-import-plugin @.> Cc: obegron @.>, Mention @.> Subject: Re: [jenkinsci/job-import-plugin] Bugfix/jenkins 64121 (PR #31) Hi @obegron, by any chance u can post/include hpi file? I really doubt that your fix will be merged to the master. thank you for fixing it! —Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

@obegron THANK U! saved my day

[aah9]

@escoem - would you mind taking a look at this pull request and merging it?

[ianwilliams1]

@escoem, I'm sure fixing the icon resolution under PR : [JENKINS-66191] Fix icon size in dashboard #32 is appreciated by some, many more would appreciate if you could merge and release this PR so as to provide basic functional compatibility with folders plugin: [JENKINS-64121] Jenkins ImportPlugin - Error '/' unsafe character. Much appreciated, pls, thx.

[LCerebo]

I had the same problem during the migration within 2 jenkins instances with the cloudbees-folder plugin.
@escoem any updates on this pull-request?