Johnbel

[JohnbelMDev]

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

• human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[JohnbelMDev]

This update includes the latest versions for dependencies and plugins

[MarkEWaite]

Closing this pull request. It does not follow the contributing guidelines and does not complete the pull request template.

[MarkEWaite]

@JohnbelMDev if you describe what you were trying to accomplish, that may help others coach you to create a successful pull request. The volume of unrelated changes in this pull request was too great for me to spend time trying to extract your original intent from the mix of changes that are included in the pull request.

[JohnbelMDev]

The pull request currently lacks a clear focus and appears to contain a significant number of unrelated changes. To help reviewers understand the purpose of this pull request and provide constructive feedback, please clarify the intended goal. Some helpful information to include: - *What specific problem are you trying to solve?* (e.g., bug fix, new feature, performance improvement, refactoring) - *What are the key changes being made?* (e.g., specific files modified, algorithms added or removed, functionality changed) - *How do these changes address the identified problem?* (e.g., explain the logic behind the modifications, provide examples of how the code behaves differently) By providing this context, you enable reviewers to: - *Quickly understand the purpose and scope of the changes.* - *Focus their attention on the most relevant parts of the code.* - *Offer more targeted and helpful feedback.* Ultimately, clarifying the intent of this pull request will increase its chances of being successfully reviewed and merged. Thank you.

…

-Johnbel Mahautiere

On Tue, Nov 12, 2024 at 12:44 PM Mark Waite ***@***.***> wrote: @JohnbelMDev <https://github.com/JohnbelMDev> if you describe what you were trying to accomplish, that may help others coach you to create a successful pull request. The volume of unrelated changes in this pull request was too great for me to spend time trying to extract your original intent from the mix of changes that are included in the pull request. — Reply to this email directly, view it on GitHub <#9965 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJVH23ZPIBAZ676KWVQBUT2AI47VAVCNFSM6AAAAABRUMPXRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGE4DMNZZG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>