Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.thoughtworks.xstream:xstream to v1.4.21 [SECURITY] #9954

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.thoughtworks.xstream:xstream (source) 1.4.20 -> 1.4.21 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47072

Impact

The vulnerability may allow a remote attacker to terminate the application with a stack overflow error resulting in a denial of service only by manipulating the processed input stream when XStream is configured to use the BinaryStreamDriver.

Patches

XStream 1.4.21 detects the manipulation in the binary input stream causing the the stack overflow and raises an InputManipulationException instead.

Workarounds

The only solution is to catch the StackOverflowError in the client code calling XStream if XStream is configured to use the BinaryStreamDriver.

References

See full information about the nature of the vulnerability and the steps to reproduce it in XStream's documentation for CVE-2024-47072.

Credits

Alexis Challande of Trail Of Bits found and reported the issue to XStream and provided the required information to reproduce it.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file skip-changelog Should not be shown in the changelog labels Nov 8, 2024
@renovate renovate bot force-pushed the renovate/maven-com.thoughtworks.xstream-xstream-vulnerability branch from ffbdca6 to 71ebffd Compare November 8, 2024 02:51
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CVE says:

All versions until and including version 1.4.20 are affected, if using XStream's BinaryStreamDriver. (emphasis added)

As far as I can tell from a search of the jenkinsci GitHub organization, the only references to BinaryStreamDriver are in the archived repositories:

Jenkins is not using the BinaryStreamDriver so is not vulnerable to CVE-2024-47072.

We should upgrade in order to avoid complaints from software composition analysis tools, even though Jenkins is not likely to be vulnerable to this issue.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De minimis

@basil basil merged commit 0bc21b9 into master Nov 8, 2024
4 of 9 checks passed
@basil basil deleted the renovate/maven-com.thoughtworks.xstream-xstream-vulnerability branch November 8, 2024 03:31
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Nov 9, 2024
…TY] (jenkinsci#9954)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
(cherry picked from commit 0bc21b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants