Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calling Nodes#setNodes, NodeListener methods should be called as required #9905

Merged

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Oct 23, 2024

For example, when loading a new casc configuration, it calls Nodes#setNodes, and the NodeListener methods were not called, causing listener implementations not to be notified according to the new state.

Testing done

Automated tests pass.

Proposed changelog entries

  • Calls to Nodes#setNodes now notify NodeListener implementations.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

… required

For example, when loading a new casc configuration, it calls Nodes#setNodes, and the NodeListener methods were not called, causing listener implementations not to be notified according to the new state.
@Vlatombe Vlatombe added the developer Changes which impact plugin developers label Oct 23, 2024
@Vlatombe Vlatombe requested a review from jglick October 23, 2024 14:21
@Vlatombe Vlatombe requested a review from a team October 24, 2024 18:15
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 24, 2024
@MarkEWaite MarkEWaite merged commit 97e1009 into jenkinsci:master Oct 25, 2024
16 checks passed
@Vlatombe Vlatombe deleted the nodes-setNodes-should-call-node-listeners branch November 4, 2024 15:56
Vlatombe added a commit to Vlatombe/jenkins that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants