-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When calling Nodes#setNodes, NodeListener methods should be called as required #9905
Merged
MarkEWaite
merged 2 commits into
jenkinsci:master
from
Vlatombe:nodes-setNodes-should-call-node-listeners
Oct 25, 2024
Merged
When calling Nodes#setNodes, NodeListener methods should be called as required #9905
MarkEWaite
merged 2 commits into
jenkinsci:master
from
Vlatombe:nodes-setNodes-should-call-node-listeners
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… required For example, when loading a new casc configuration, it calls Nodes#setNodes, and the NodeListener methods were not called, causing listener implementations not to be notified according to the new state.
jglick
reviewed
Oct 23, 2024
jglick
reviewed
Oct 23, 2024
jglick
reviewed
Oct 23, 2024
jglick
reviewed
Oct 23, 2024
jglick
approved these changes
Oct 23, 2024
jglick
approved these changes
Oct 24, 2024
timja
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
comment-ops-bot
bot
added
the
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
label
Oct 24, 2024
Vlatombe
added a commit
to Vlatombe/jenkins
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
developer
Changes which impact plugin developers
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when loading a new casc configuration, it calls
Nodes#setNodes
, and theNodeListener
methods were not called, causing listener implementations not to be notified according to the new state.Testing done
Automated tests pass.
Proposed changelog entries
Nodes#setNodes
now notifyNodeListener
implementations.Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist