Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run generate-weekly-changelog.sh failed #9874

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

shenxianpeng
Copy link
Contributor

See jenkinsci/core-changelog-generator#37

Testing done

Proposed changelog entries

  • Fix run generate-weekly-changelog.sh failed

Proposed upgrade guidelines

N/A

Desired reviewers

@timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Oct 15, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@MarkEWaite
Copy link
Contributor

Thanks! I've pushed the same change to the fix-changelog-script branch on the repository and am running the changelog drafter action from that branch now. Results should be visible in https://github.com/jenkinsci/jenkins/actions/runs/11350472763

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 15, 2024

Thanks! I've pushed the same change to the fix-changelog-script branch on the repository and am running the changelog drafter action from that branch now. Results should be visible in https://github.com/jenkinsci/jenkins/actions/runs/11350472763

That seemed like a good idea but when the changelog drafter ran in that job, it reported a failure inside the Python script. The failure was related to date parsing an empty return value from git log. I assume that means the virtual environment was created correctly and this can be merged.

@MarkEWaite
Copy link
Contributor

Merging immediately because the CI checks are not useful for this pull request

@MarkEWaite MarkEWaite merged commit c41791e into jenkinsci:master Oct 15, 2024
5 of 11 checks passed
@MarkEWaite
Copy link
Contributor

Confirmed that the changelog drafter is running again. Thanks very much @shenxianpeng !

@shenxianpeng shenxianpeng deleted the fix-changelog-script branch October 15, 2024 17:34
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for moving the change here! +1

@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants