-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override the outdated managed dependency on asm
in guice-parent
#9827
Conversation
For reference : google/guice#1822 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(until we can get rid of Guice which should never have been added to Jenkins to begin with)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
…`guice-parent` (jenkinsci#9827) Override the outdated managed dependency on `asm` in `guice-parent` (cherry picked from commit 0066184)
Amends #9182 to reduce our exposure to jenkinsci/plugin-pom#1032. Today,
jenkins-bom
is delivering a managed dependency onasm
9.5, coming from Guice. While it is bad that we deliver any reference to ASM fromjenkins-bom
, it is even worse that we deliver an old one. This overrides the old version to a more recent one, which is a strict improvement over the status quo. It is not a complete long-term solution to the problem, but it will surely not make things any worse than they are today, and will make them better in some cases.Testing done
jenkinsci/workflow-job-plugin#471 exhibits the problem before this PR and passes after this PR.
Deployment plan
I plan to backport this to 2.479.1 LTS. Until that is generally available, I will re-introduce a workaround in
plugin-pom
(effectively reverting jenkinsci/plugin-pom#918 for a few weeks).Proposed changelog entries
Developer: Prevent an old version of ASM from appearing as a managed dependency in plugin builds.
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist