Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73785] Restore ContextMenu#from with StaplerRequest/Response args #9737

Merged
merged 1 commit into from
Sep 17, 2024
+4 −0
Merged

[JENKINS-73785] Restore ContextMenu#from with StaplerRequest/Response args #9737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,10 @@
return from(self, request, response, "sidepanel");
}

public ContextMenu from(ModelObjectWithContextMenu self, StaplerRequest request, StaplerResponse response) throws JellyException, IOException {
return from(self, StaplerRequest.toStaplerRequest2(request), StaplerResponse.toStaplerResponse2(response), "sidepanel");

Check warning on line 303 in core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 303 is not covered by tests
Copy link
Member Author

@daniel-beck daniel-beck Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively,

Suggested change
return from(self, StaplerRequest.toStaplerRequest2(request), StaplerResponse.toStaplerResponse2(response), "sidepanel");
return from(self, StaplerRequest.toStaplerRequest2(request), StaplerResponse.toStaplerResponse2(response));

?

}

public ContextMenu from(ModelObjectWithContextMenu self, StaplerRequest2 request, StaplerResponse2 response, String view) throws JellyException, IOException {
WebApp webApp = WebApp.getCurrent();
final Script s = webApp.getMetaClass(self).getTearOff(JellyClassTearOff.class).findScript(view);
Expand Down
Loading