[JENKINS-73695] Prevent unnecessary horizontal scrollbar in Firefox

[scherler]

See JENKINS-73695.

Testing done

Interactive tests with Firefox

Proposed changelog entries

• Prevent unnecessary horizontal scrollbar in Firefox.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
4. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
5. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
6. For dependency updates, there are links to external changelogs and, if possible, full differentials.
7. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[scherler]

Follow up for #9667 which produced a horizontal scrollbar in FF

[janfaracik]

You could remove the top margin from .jenkins-icon-size, e.g.

.jenkins-icon-size {
  display: flex;
  align-items: center;
  justify-content: space-between;
  margin: 0 0 var(--section-padding) 0;

  ...
}

[scherler]

@janfaracik just tried that but it did not work in FF

[janfaracik]

Seems like it's the ::after pseudo element on the table causing the overflow in Firefox, maybe have a media query to only apply that styling for non Firefox browsers?

[scherler]

@janfaracik added the media query now instead of reducing the width

[MarkEWaite]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

[daniel-beck]

This should have a different Jira issue than the original issue so this can be backported into LTS.