Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PathRemoverTest timeout in RISC-V devices. #9661

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

qyl27
Copy link
Contributor

@qyl27 qyl27 commented Aug 26, 2024

I am working in Arch Linux RISC-V port.
RISC-V devices have extremely low performance, 10 seconds timeout in PathRemoverTest is too short to pass in these devices.
After my test, changing it to 30 seconds can pass tests.
That is a minor change, so I haven't created an issue in Jira.

Testing done

It simply increases the timeout and is tested in our compile machines.

Proposed changelog entries

  • Increase timeout in PathRemoverTest for RISC-V devices.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

Sorry, I don't know which team should be mentioned.

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Aug 26, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@daniel-beck
Copy link
Member

RISC-V devices have extremely low performance, 10 seconds timeout in PathRemoverTest is too short to pass in these devices.
After my test, changing it to 30 seconds can pass tests.

Could you confirm that all other tests pass, including those in test/? I would expect running the Jenkins tests on a low power device being at least impractically slow.

@qyl27
Copy link
Contributor Author

qyl27 commented Aug 26, 2024

RISC-V devices have extremely low performance, 10 seconds timeout in PathRemoverTest is too short to pass in these devices.
After my test, changing it to 30 seconds can pass tests.

Could you confirm that all other tests pass, including those in test/? I would expect running the Jenkins tests on a low power device being at least impractically slow.

Yes, It has passed all tests after my patch in HiFive Unmatched.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@timja timja added the skip-changelog Should not be shown in the changelog label Aug 26, 2024
@timja timja merged commit 9045a3d into jenkinsci:master Aug 26, 2024
15 checks passed
Copy link

welcome bot commented Aug 26, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants